Hello guys, I want to make some changes into sourc...
# help
n
Hello guys, I want to make some changes into source files and rebuild "lakectl". I downloaded github repository, ran "docker-compose up". Next made some changes in source files and trying to rebuild lakectl by "make all". New binary file appears into root of the project, but looks like that new file doesn't have my changes. Am I doing something wrong?
b
hi, the binary you built should include you changes - can you share your git diff
👍 2
I can apply the change locally and see what you see.
use
-u
for unified/patch format
or push it to your fork and send me a link
s
the .env file has
TAG=latest
which means docker-compose tries to fetch
treeverse/lakefs:latest
image (from docker repo). In order to build an image from source code there are a couple of ways 1. replace
image: "treeverse/lakefs:${TAG}"
with
build : .
in docker-compose file 2. Another way is to build an image with
dev
tag. To do that change
TAG=dev
in
.env
and run
make build-docker
. Then do
docker-compose up
I am also completely new to this repo so not sure which one of this is the recommended way to do this. Probably @Barak Amar can suggest.
b
both ways are valid. thought the compiled version is used outside as a CLI that connects to the running service.
s
agreed. If the source code changes are pertaining only to lakectl command then no need to make a docker image. Just
docker-compose up
and use lakectl from host