Hi, I'm trying to add authorization to the new api...
# helpu
אילון רונן
10/04/2020, 8:07 AMHi, I'm trying to add authorization to the new api endpoint I created in PR #751, but I don't understand how to test it
b
Barak Amar
10/04/2020, 8:32 AM
Hi, adding new api - api/api_controller.go can be tested using api/api_controller_test.go
Barak Amar
10/04/2020, 8:33 AM
each func TestHandlerXXX function there setup an env for testing our api handlers
Copy code
handler, deps := getHandler(t)Barak Amar
10/04/2020, 8:33 AM
from there it will be calling the new implemented api and test the expected results
Barak Amar
10/04/2020, 8:36 AM
In case you need to setup a different block adapter or mock it in a different way - you can check how we setup the handler in the
getHandleru
אילון רונן
10/04/2020, 10:26 AMI wrote a test, and it passes whether I use setupRequest or not... I feel like I'm missing something
אילון רונן
10/04/2020, 10:26 AMI pushed the latest version with test and all
אילון רונן
10/04/2020, 10:27 AMCan you have a look?
b
Barak Amar
10/04/2020, 11:16 AM
I'll take a look soon
Barak Amar
10/04/2020, 11:16 AM
image.png
Barak Amar
10/04/2020, 11:17 AM
you can hit the re-request review when you are done
Barak Amar
10/04/2020, 11:23 AM
the review will get the notification
u
אילון רונן
10/04/2020, 11:53 AMמטורף!
אילון רונן
10/04/2020, 11:53 AMלא הכרתי את זה
אילון רונן
10/04/2020, 11:53 AMתודה רבה לך
👍 1