sumesh kanayi
05/27/2021, 12:17 PMItai Admi
05/27/2021, 12:40 PMS3
, GCS
, Azure Blob Storage
and few non-prod like local
and mem
. All block stores implements the same adapter, so it should be the best place to start. Read our contribution guide for general guidelines.
I am also interested to know what is the potential use-case for Manta<->lakeFS integration and how we could help Manta users even more.sumesh kanayi
05/31/2021, 11:21 AMItai Admi
05/31/2021, 11:29 AMsumesh kanayi
06/21/2021, 6:57 PMcommit: close writer ns=<manta://sumesh-demo-2> id=: batch write closer wait: sstable store (2c9f1ab23b771c1702cfa9ef3ff72dfe023cfd1a876dadf254732a7bb08a0f03): closing file 2c9f1ab23b771c1702cfa9ef3ff72dfe023cfd1a876dadf254732a7bb08a0f03: close /Users/sdata/lakefs/cache/range/sumesh-demo-2/workspace/d4b16c91-a56c-4588-85ad-579efe6d01b9: file already closed
It seems like getting failed here
https://github.com/treeverse/lakeFS/blob/6a01ee35453fee68b784500a8a7062ac10f75dcc/pkg/graveler/sstable/writer.go#L149Guy Hardonag
06/21/2021, 7:26 PM_lakefs
?
Does it happen every time you try to commit?
What lakeFS version are you using?sumesh kanayi
06/21/2021, 7:30 PMmls ~~/stor/sumesh-demo-2/_lakefs
2c9f1ab23b771c1702cfa9ef3ff72dfe023cfd1a876dadf254732a7bb08a0f03
one thing noticed is that i cant see any actions/log
directory under _lakefs .I am running the latest version from master.Yes this happens every-time when i commitGuy Hardonag
06/21/2021, 7:36 PMGuy Hardonag
06/21/2021, 7:36 PMGuy Hardonag
06/21/2021, 7:37 PMGuy Hardonag
06/21/2021, 7:59 PMsumesh kanayi
06/22/2021, 3:42 AMsumesh kanayi
06/22/2021, 3:43 AMYoni Augarten
06/22/2021, 5:32 AMsumesh kanayi
06/22/2021, 10:26 AMYoni Augarten
06/22/2021, 10:28 AMsumesh kanayi
06/22/2021, 10:29 AMsumesh kanayi
06/22/2021, 10:32 AMYoni Augarten
06/22/2021, 10:39 AMYoni Augarten
06/22/2021, 10:39 AMYoni Augarten
06/22/2021, 10:41 AMYoni Augarten
06/22/2021, 10:41 AMYoni Augarten
06/22/2021, 11:05 AMreader
. This will cause the code at tier_gs.go:162
to fail when it tries closing it again. Can you check if that's really what happens?sumesh kanayi
06/22/2021, 11:32 AMsumesh kanayi
06/22/2021, 11:37 AMYoni Augarten
06/22/2021, 11:50 AMblock/s3/adapter.go:192
- we wrap the reader with a NopCloser.sumesh kanayi
06/22/2021, 12:01 PMtier_gs.go:162
.Got it..block/s3/adapter.go:192
certainly is super helpful.I will let you know how it goesYoni Augarten
06/22/2021, 12:01 PMsumesh kanayi
06/23/2021, 6:35 PMfunc (l *Adapter) Remove(_ context.Context, obj block.ObjectPointer)
as you can see under <https://github.com/treeverse/lakeFS/blob/master/pkg/block/local/adapter.go#L143>
couldn't find out when it really comes under play. Do we need to implement it to remove objects/buckets ? When i tried using "local" block i dont see it really deleting from file system but its updated under UI as deleted .So what exactly this method do?Guy Hardonag
06/23/2021, 7:52 PMhard delete
and it will be used in the future (probably as part of this issue).sumesh kanayi
06/24/2021, 5:21 PM