Itai Admi10/21/2021, 2:03 PM
Guy Hardonag10/21/2021, 2:59 PM
file because the release task included going over all the commits and talking with all the committers in order to understand what should go in the changelog. Maybe we should give something else a shot before going back.
Ariel Shaqed (Scolnicov)10/21/2021, 5:49 PM
Karen10/22/2021, 7:12 AM
For one thing it would be really nice to be able to clearly distinguish what is a bug fix and what is a new feature. So, in bug fixes it would be nice to have the word "fix" / "fixed" etc. Everything else would be seen as a new feature.
- Airflow hook nil assignment fix - Bug fix: pyramid store file fallback when destination already exist in cache - Bugfix/2400 change error message repo with new storage type - Fix UI base branch changes compare branch - UI - keep path when changing reference in object view - Using simple mime library that gives a consistent content-type on all platforms
Itai Admi10/24/2021, 5:43 AM
and enforce using at least one of them in the PR
Itai Admi10/24/2021, 6:33 AM
Ariel Shaqed (Scolnicov)10/24/2021, 7:17 AM
Karen10/24/2021, 7:55 AM
Tal Sofer10/25/2021, 6:32 AM
• Check if the issue closed by the PR has a
Guy Hardonag10/25/2021, 6:57 AM
into more specific labels (such as
Barak Amar10/26/2021, 10:00 AM
Itai Admi10/26/2021, 1:34 PM
it will just make me automate a label on my every new PR.Which is the exact opposite of what we’re trying to achieve. Why would someone maliciously do that? The entire purpose is to flag if changelog should reflect the changes in the PR.
We can use a prefix as part of the PR title to filter out non-customer facing changes and let goreleaser generate the chanagelogWhy is a prefix better than a tag? We need some automation and tag is cleaner.
the CHANGELOG doesn’t hold just the PR description. It hold the bug or feature description associated to the PR.This is exactly where we need to improve. The description should include the new feature description, the bug fix and not implementation details. This is exactly what the changelog currently holds.
that the file is always updated after the change or get conflicts all the time, if we update it during our development.Changelog updates once before release, now manually, later on we can add automation.
Barak Amar10/26/2021, 2:23 PM
Itai Admi10/26/2021, 2:51 PM
Barak Amar10/26/2021, 2:54 PM
Ariel Shaqed (Scolnicov)10/26/2021, 2:56 PM
Itai Admi10/26/2021, 2:57 PM
Barak Amar10/26/2021, 3:03 PM