Working on the content diff feature and looking for feedback on visualisation - Specifically speaking, after adding the content diff feature, a directory and object entries differ only in their icon and directories ends with the “/” separator. both are expandable and the results of expanding them are different. @Oz Katz do you have thoughts about this?

I think it’s an action that should reside in the right side, next to revert with a suitable diff icon (perhaps

<>

?). The way it is now is that we have the same icon which does 2 different things (expanding or diffing) depending on a different icon on the left.

the accordion style folding that @Tal Sofer used is basically what GitHub and GitLab use for commit change visualization. I personally don't find it confusing: "drilling down" into a directory shows the diff within a directory. "drilling down" into an object shows the diff within the object). Assuming we don't want to further complicate the UI with toggles, we should probably do a vertical diff instead of the horizontal one as it will cause lines to wrap for larger text/csv files, which are probably very common

I like the idea of moving the icon to the right side, Adding one thing, the inspiration for using the

>

icon comes from github. But, github don’t do objects listing 🙂 How about using the icon in the screenshot (which means “Expand all” in github)?

btw @Tal Sofer a thing worth looking into: what happens if a user modified a few non-contiguous lines in the file? with GitHub/etc, it would give a few lines of context before/after each change and won't display the entire thing. What do we do?

Will take a look, thanks

this is the icon:

Yes, about the icon for expand. As an operation there are two others: https://www.iconsdb.com/black-icons/compare-icon.html or https://www.iconsdb.com/black-icons/compare-icon.html

no color - maybe just when selected gets the "selection" - but I think it is already done for you

when selected gets the “selection”

What do you mean? how do you expect that to look like after clicking?

When I wrote no color for the icons - black. The icon is like text and should be rendered black as we do for the text. When the icon is actionable - it should be also addressed visually by embed into a button or a link.