Does anyone know how to add fields from context to...
# deva
Ariel Shaqed (Scolnicov)
11/10/2021, 7:14 AMDoes anyone know how to add fields from context to those emitted by an AWS client? This is for https://github.com/treeverse/lakefs/issues/2682.
Context (sorry): Looking to "thread" our request_id field throughout all lakeFS logs. One issue that has me confused is how to get AWS to log with request IDs. Something like https://github.com/aws/aws-sdk-go/pull/3485 would be great, but that PR went silent. I do no want to dupe the client only to change its configuration, that may be overpowering for the issue.
Ariel Shaqed (Scolnicov)
11/10/2021, 7:20 AMhttps://aws.github.io/aws-sdk-go-v2/docs/configuring-sdk/logging/#context-aware-loggers may be an answer, but requires using AWS Go SDK v2. @Barak Amar do you know if this major version bump is worthwhile / safe?
b
Barak Amar
11/10/2021, 7:21 AM
Last time I checked it was beta - looking again
a
Ariel Shaqed (Scolnicov)
11/10/2021, 7:29 AMhttps://docs.aws.amazon.com/sdkref/latest/guide/version-support-matrix.html says "full support" IIUC.
Ariel Shaqed (Scolnicov)
11/10/2021, 7:30 AMLet's continue this discussion on the issue that I'm opening.
b
Barak Amar
11/10/2021, 7:31 AM
Looks like they leverage the go modules to have different releases for each service. Modern "WithXXX" API for configuration. Cache for credentials. Iterator vs callback for pagination.
Barak Amar
11/10/2021, 7:31 AM
Good idea
a
Ariel Shaqed (Scolnicov)
11/10/2021, 7:34 AM#2684
👍 1
Ariel Shaqed (Scolnicov)
11/10/2021, 7:37 AMA v2 interface that actually tries to improve on known deficiencies in the v1 interface... Just pinched myself, apparently not dreaming.
4 Views