Does anyone understand why tests are not run autom...
# deve
Edmondo Porcu
03/29/2022, 3:31 AMDoes anyone understand why tests are not run automatically on a new commit on a Pull request ? It says "Waiting reporting of status check" or something similar on each check. It would be handy if one could just click and jump to the workflow execution instead
b
Barak Amar
03/29/2022, 6:23 AM
Currently the system tests uses our could environment and require confirmation on our end for PR from a fork. We are looking into alternative way to enable this without our confirmation.
Barak Amar
03/29/2022, 6:38 AM
The draft PR 3080?
Barak Amar
03/29/2022, 6:57 AM
Can we switch it out of draft?
e
Edmondo Porcu
03/30/2022, 2:37 PMsure
Edmondo Porcu
03/30/2022, 2:38 PMI need to rebase now 😞
b
Barak Amar
03/30/2022, 2:39 PM
Tests were triggered - ping me if you need re-test
e
Edmondo Porcu
03/30/2022, 6:50 PMSo was it the draft status?
Edmondo Porcu
03/30/2022, 6:51 PMI need to rebase, ugh!
Edmondo Porcu
03/30/2022, 6:52 PMCan you please stop other PR to be merged if they go in the lakefs/cmd package while we get mine through?
Edmondo Porcu
03/30/2022, 7:23 PM@Barak Amar can you re-run the testS?
👍 1
b
Barak Amar
03/30/2022, 7:24 PM
Not sure they are pending changes there, need help with the rebase?
Barak Amar
03/30/2022, 7:26 PM
will add my feedback by tomorrow, thought it was still a draft
Barak Amar
03/30/2022, 7:26 PM
thank you for the code contribution
e
Edmondo Porcu
03/30/2022, 8:23 PMnewbie error, I didn't run lint on my machine 😞
Edmondo Porcu
03/30/2022, 8:32 PMCan you rerun the test?
✅ 1
Edmondo Porcu
04/02/2022, 11:06 PM@Barak Amar could you please rerun the tests?
👍 1
Edmondo Porcu
04/03/2022, 3:00 PM@Barak Amar could you please rerun them again?
Edmondo Porcu
04/03/2022, 3:00 PMI forgot to lint, as usual. I really need a pre-commit handler for it 😄
👍 1
b
Barak Amar
04/03/2022, 3:03 PM
Sorry my review still not there yet
Barak Amar
04/03/2022, 3:03 PM
Still working on it
4 Views