https://lakefs.io/ logo
Title
t

Tamir Zheleznyak

11/14/2022, 3:51 PM
Hey, • What is the default expiration for token given by login request? Can i modify it? Maybe its good idea to add the expiration to the body of the response of the login request? • There is a way to alter the commiter name of commit in the body of the request:
"POST", "repositories/%s/branches/%s/commits"
i

Itai Admi

11/14/2022, 4:09 PM
Hey Tamir, I assume you are referring to UI usage. Let me know if that’s not the case. • The default token is valid for 1 week and not modifiable at the moment. • Committing thru the UI is using the authenticated user as the committer. The API does supports passing this value though. Can you share some more details on why you’d want a different committer name?
t

Tamir Zheleznyak

11/14/2022, 4:52 PM
Im talking with rest api Im integrating to my go-code services fuctions that do rest operations to lakefs
i

Itai Admi

11/14/2022, 5:12 PM
Updating my previous answer. There isn’t an option in the API to change the committer name. I was wondering on the reasons for changing the committer name. There’s the
message
field that might assist with short descriptions of a commit. Or the metadata field which is a dictionary given by the caller. We usually see some labelling done by the metadata, for instance
{"job": "extract-entities", "worker": "spark-123", …}
t

Tamir Zheleznyak

11/14/2022, 5:23 PM
Yeah the metadata i good option for my usecase, the commiter name thing is more as a nice to have not critical for me. What about the expiration of token given by api/v1/auth/login?
i

Itai Admi

11/14/2022, 5:25 PM
It’s a constant 1 week at the moment. What usage are you aiming for?
t

Tamir Zheleznyak

11/14/2022, 5:27 PM
For lakefs as helm k8s application in same cluster running the app accessing it. Just thought from security perspective a token with configurable expiration where I can put a smaller time might be more secure for us. Something like half hour - 1 hour expiration so In case token stolen it won't work after that
i

Itai Admi

11/14/2022, 5:32 PM
Yeah, it makes sense! Feel free to open an issue describing the use case so we can prioritize 🙂
👍 1
t

Tamir Zheleznyak

11/14/2022, 5:35 PM
Thanks. Opened one https://github.com/treeverse/lakeFS/issues/4595
:sunglasses_lakefs: 1
📝 1
i

Itai Admi

11/14/2022, 5:36 PM
Great, many thanks!! It’s issues like this that help us improve lakeFS
t

Tamir Zheleznyak

11/16/2022, 9:10 AM
I see you entered this to master. First of all thanks for the quick win. Is it availiable now for helm installation if we want to update and have it ?
i

Itai Admi

11/16/2022, 9:20 AM
Happy to help, and kudos to @Guy Hardonag for the quick and efficient work. Not yet, we need to release lakeFS first. How urgent is this for you? Assuming no urgent releases, we normally release lakeFS every 2 weeks.
:lakefs: 1
t

Tamir Zheleznyak

11/16/2022, 9:22 AM
2 weeks is good for us 🙂
🙏 1