<@U018PQSEPDE> thank you It worked Notebook is up ...
# help
a
@Itai Admi thank you It worked Notebook is up and running after running above commands. Still Hive and compose_spark-thrift_1 is not up
i
@Ashwath It doesn’t reproduce on my mac. Trying to get to the bottom of it with a Windows machine..
b
Hi @Ashwath, can you edit the file
hive/Dockerfile
and add the following line, after
COPY entrypoint.sh /
Copy code
RUN chmod +x /entrypoint.sh
Following, in the docker-compose directory run the same as before - docker-compose down, build and up. In case hive is still reporting an error, send the output of:
Copy code
docker-compose logs hive-metastore
i
Hey @Barak Amar, I did just that on my Windows machine and got the same error:
Copy code
C:\Users\User\code\lakefs\deployments\compose> docker-compose logs hive-metastore
Attaching to hive
hive                      | /bin/sh: 1: /entrypoint.sh: not found
b
@Itai Admi what was the output in the build step under hive?
alt. go to the hive folder and run
Copy code
docker build -t hive .
a
@Itai Admi its same error
i
The build passed successfully, I have a running bash inside the container and the
entrypoint.sh
is indeed missing, trying to figure out what went wrong
a
image.png
i
Thanks @Ashwath I’m able to reproduce on my Windows, debugging it with @Barak Amar on this thread 🙂
🙌 1
a
Thanks a lot :)
b
@Itai Admi the entrypoint is missing inside the container, there is a COPY command (verify the output of the build) that copy it to the image. Or there is no entrypoint inside the hive directory?
b
so it is the git settings
you can control when you checkout the file as \r\n or \n
think we can force it to specific files
can you verify first on windows that this one works?
👍 1
i
It didn’t. I just checked out the
bugfix/bagel-bash
branch. Is there something else I need to do for the changes to apply?
Adding
RUN sed -i -e 's/\r$//' entrypoint.sh
to the Dockerfile solved it for
hive
but we don’t have a Dockerfile for
spark-thrift
which is failing for the same reasons.
b
checking if the attributes spec should be in the same folder
per path
pushed a change
i
nope, still
b
after switching to the PR branch - can you check out the specific object - entrypoint.sh
i
It remains the same
I can still see it has CRLF line endings
So forcing
/r/n -> /n
conversion with notepad+, solved it for
hive
container (with Dockerfile), but for
spark-thrift
container (just a mount of that file) I still get the same error
b
there is a shell script there too
i
@Barak Amar pls have another look at the PR, I think the hack I did got us covered. @Ashwath I tested it myself, do you mind double checking it? checkout
bugfix/bagel-bash
, and run docker-compose down, build and up and see if it’s fixed?
a
@Itai Admi what you want me to check ?
@Itai Admi
bugfix/bagel-bash
, is this command to run.. ? if yes please let me know where and what is full command. i could not see in docker-compose
i
That's the branch
You should run
git checkout bugfix/bagel-bash
a
@Itai Admi I see this error : pathspec 'bugfix/bagel-bash' did not match any file(s) known to git
i
Try
git fetch
before
1
a
@Itai Admi build is success but hive still failing
image.png
b
Hi @Ashwath we are looking into how to force the entrypoint to encode as unix format
The specific branch that itai specify should enable it . Will update as soon as we have it working.
a
okie, thank you @Barak Amar
i
Hey @Ashwath I see that the
spark-thrift
container was able to run. I made another push to the same branch
bugfix/bagel-bash
for the
hive
container. Could you try again,
git fetch
,
git pull
, then docker-compose down, build, up and see if that helps? FYI this is just to get you unblocked, the actual fix should be cleaner than what currently exists in this branch..
@Barak Amar from @Ashwath response I understand that the
.gitattribute
file did not force line endings on his machine
b
@Itai Admi from the last response the hive still fails
a
@Itai Admi Build failed , @Barak Amar yes hive is still failing. spark-thrift was up last time , did not check now
i
Exactly, the .gitattributes should fix that. I’m trying to build a Dockerfile for the
spark-thrift
which should fix this as it did for the
hive
@Ashwath Can you try one more time please? the branch should have the fix now.
fetch -> pull -> down -> build -> up
Thanks for all your patience and help, much appreciated!
a
@Itai Admi not a problem trying it Now great to know that all services up & running. great effort. Thank you so much What next i have to wait till PR to main branch and i need to checkout to main branch something similar.. ?
i
Yes, we’ll merge it soon
🚀 1
🙌 1
Happy to help 🙂
🙌 1
@Ashwath It’s now merged into
master
branch. You can checkout that branch, run
git checkout-index --force --all
to sync the files. When you build the containers, make sure you skip the cache usage:
docker-compose build --no-cache
.
🙌 1
a
@Itai Admi sorry for coming late. I switched to master and build without cache. but still hive is throwing error as /bin/sh: 1: /entrypoint.sh: not found
y
Hey @Ashwath, can you make sure your master branch is pulled to the latest?
1
I will try this on a Windows machine again soon
a
yes its pulled
y
Ok, let me check
@Ashwath, it took me a while to spin Docker on a Windows machine 🙂. But after doing so, I was not able to reproduce the issue. Let's take it in private and try to solve it together
a
@Yoni Augarten okie. sure but how.
👀 1