Vishal K

08/24/2023, 11:00 PM
Hi, can someone please take a look at my PR ?

Ariel Shaqed (Scolnicov)

08/25/2023, 4:56 AM
Hi @Vishal K, Sorry we missed this PR! It looks good, but I'm not sure it's taking this API where we want it to go. My concern is that I want to remove it entirely. This is only a concern: I am certainly not running out this change! I added some comments on the PR. I would prefer to discuss on the PR where I feel we keep more context. But we can discuss wherever you do reply.