Hello there I was assigned with the issue 5605 and wanted so

Question

Hello there I was assigned with the issue 5605 and wanted some help about it

Or Tzabary · Answer

hey < Mohammad Umair> what kind of help do you need

Mohammad Umair · Answer

Thanks for the reply I am new to open source The issue is Remove unused code from MetaRangeManager 5605 How can i get started Can you help with that I have to make this contribution please

Or Tzabary · Answer

See our contribution guide to get started <https docs lakefs io contributing|https docs lakefs io contributing>

Or Tzabary · Answer

Anything in specific you d like to know

Mohammad Umair · Answer

I have searched the keyword metarangeManager and In <https github com treeverse lakeFS blob master pkg graveler committed manager test go|lakeFS blob HEAD pkg graveler committed manager test go> Found this code that is commented and unused at line no 96 to 102

Mohammad Umair · Answer

Do i have to remove this and make a PR Please guide me Sorry for inconvenience I am new

Iddo Avneri · Answer

HI < Mohammad Umair> Feel free to follow these steps to create A PR with your changes

Mohammad Umair · Answer

< Iddo Avneri> can you please guide me on this

Iddo Avneri · Answer

I m referring to this section 1 Review this document in full 2 Make sure there s an open that this pull request addresses and that it isn t labeled `x wontfix` 3 the 4 If you re adding new functionality create a new branch named `feature lt DESCRIPTIVE NAME gt ` 5 If you re fixing a bug create a new branch named `fix lt DESCRIPTIVE NAME gt lt ISSUE NUMBER gt `

Iddo Avneri · Answer

I think you are in step 3

Mohammad Umair · Answer

Yes Before making a PR i needed somr help

Iddo Avneri · Answer

Which step do you need help with

Iddo Avneri · Answer

If the question is about what you need to do in the code in order to address the issue I suggest having that conversation directly on gitHub

Mohammad Umair · Answer

Finding the File I need to remove unused code from I have searched the keyword metarangeManager and In <https github com treeverse lakeFS blob master pkg graveler committed manager test go|lakeFS blob HEAD pkg graveler committed manager test go> Found this code that is commented and unused at line no 96 to 102

Iddo Avneri · Answer

I see I think that is an implementation question of how to address this issue

Mohammad Umair · Answer

Yes

Iddo Avneri · Answer

I suggest having that discussion directly on the issue

Iddo Avneri · Answer

Mohammad Umair · Answer

Ok thanks will do The opener of the issue sent me to slack to seek help if i wanted

Iddo Avneri · Answer

OK THank you

Iddo Avneri · Answer

I ll ping Itay as well to address when he is back in the office

Iddo Avneri · Answer

Appreciate your help on this

Mohammad Umair · Answer

Thanks

Iddo Avneri · Answer

Thank YOU

Niro · Answer

< Mohammad Umair> Hi just wanted to make sure you have everything you need to work on the issue If you have any questions please let us know