beginners question the linting failed on <https github com t lakeFS #dev

beginners question: the linting failed on <a small...

Robin Moffatt

03/13/2023, 11:19 AM

beginners question: the linting failed on a small PR I made. How do I run that locally to catch this before getting as far as the PR?

Barak Amar

03/13/2023, 11:24 AM

make checks-validator

Barak Amar

03/13/2023, 11:25 AM

we should make it shorter

Robin Moffatt

03/13/2023, 11:32 AM

thanks

Robin Moffatt

03/13/2023, 11:35 AM

Copy code

$ make checks-validator
/opt/homebrew/bin/go mod download
/opt/homebrew/bin/go install <http://github.com/golangci/golangci-lint/cmd/golangci-lint|github.com/golangci/golangci-lint/cmd/golangci-lint>
/opt/homebrew/bin/go install <http://google.golang.org/protobuf/cmd/protoc-gen-go|google.golang.org/protobuf/cmd/protoc-gen-go>
/Users/rmoff/go/bin/golangci-lint run
WARN [runner] Can't run linter goanalysis_metalinter: gofmt: can't extract issues from gofmt diff output "--- /Users/rmoff/git/lakeFS/pkg/permissions/actions.gen.go.orig\t2023-03-13 11:30:11\n+++ /Users/rmoff/git/lakeFS/pkg/permissions/actions.gen.go\t2023-03-13 11:30:11\n@@ -1,5 +1,4 @@\n // Code generated by extract_actions. DO NOT EDIT.\n-//\n package permissions\n \n var Actions = []string{\n": can't parse patch: parsing time "2023-03-13 11:30:11" as "2006-01-02 15:04:05 -0700": cannot parse "" as "-0700"
ERRO Running error: 1 error occurred:
        * can't run linter goanalysis_metalinter: gofmt: can't extract issues from gofmt diff output "--- /Users/rmoff/git/lakeFS/pkg/permissions/actions.gen.go.orig\t2023-03-13 11:30:11\n+++ /Users/rmoff/git/lakeFS/pkg/permissions/actions.gen.go\t2023-03-13 11:30:11\n@@ -1,5 +1,4 @@\n // Code generated by extract_actions. DO NOT EDIT.\n-//\n package permissions\n \n var Actions = []string{\n": can't parse patch: parsing time "2023-03-13 11:30:11" as "2006-01-02 15:04:05 -0700": cannot parse "" as "-0700"

make: *** [lint] Error 3

something up with my local timezone setting? or s'thing else?

Barak Amar

03/13/2023, 11:44 AM

the issue is related to your diff command

Barak Amar

03/13/2023, 11:45 AM

brew install diffutils

Barak Amar

03/13/2023, 11:46 AM

not next to my laptop to verify

Robin Moffatt

03/13/2023, 11:47 AM

sorry, I've realised that

make checks-validator

is there in the docs, i should have RTFMd…

Robin Moffatt

03/13/2023, 11:47 AM

brew install diffutils

fixed things too, I'll add a note to

contributing.md

😨 1

Robin Moffatt

03/13/2023, 11:47 AM

thanks @Barak Amar

lakefs 1

Barak Amar

03/13/2023, 12:04 PM

Thanks, added small comment to the pr.

159 Views

Open in Slack

Previous Next